{"id":153,"date":"2021-01-11T13:39:40","date_gmt":"2021-01-11T05:39:40","guid":{"rendered":"https:\/\/www.tonghin.com.my\/blog\/?p=153"},"modified":"2021-01-11T13:39:41","modified_gmt":"2021-01-11T05:39:41","slug":"code-review-on-modules","status":"publish","type":"post","link":"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/","title":{"rendered":"Code Review on Modules"},"content":{"rendered":"\n<p>For the last week of my internship, I&#8217;ve performed code review on each module that I responsible for. I&#8217;ve clean up some redundant codes and functions, renamed variables to be more understandable. Not only that, I&#8217;ve also wrote comments to clarify the implementation logic for some functions. <\/p>\n\n\n\n<p>Secondly, during the code review, I&#8217;ve also learned on the usage of Enum, which can be used to replace or represent a  group of&nbsp;constants. In my case, instead of assigning magic strings as the line item&#8217;s pick status, I&#8217;ve replaced it with Enum which contains the variety of pick status. <\/p>\n\n\n\n<p>Lastly, I&#8217;ve moved all the magic strings to Parameter class. By using parameter class, it become more maintainable to all the strings inside the whole solution. For example, changing of dialog message will only require to change the string in parameter class.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>For the last week of my internship, I&#8217;ve performed code review on each module that I responsible for. I&#8217;ve clean up some redundant codes and functions, renamed variables to be more understandable. Not only that, I&#8217;ve also wrote comments to clarify the implementation logic for some functions. Secondly, during the code review, I&#8217;ve also learned &hellip; <\/p>\n<p class=\"link-more\"><a href=\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\" class=\"more-link\">Continue reading<span class=\"screen-reader-text\"> &#8220;Code Review on Modules&#8221;<\/span><\/a><\/p>\n","protected":false},"author":3,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":[],"categories":[5],"tags":[46,45],"yoast_head":"<!-- This site is optimized with the Yoast SEO plugin v15.7 - https:\/\/yoast.com\/wordpress\/plugins\/seo\/ -->\n<title>Code Review on Modules | Tong Hin&#039;s Blog<\/title>\n<meta name=\"robots\" content=\"index, follow, max-snippet:-1, max-image-preview:large, max-video-preview:-1\" \/>\n<link rel=\"canonical\" href=\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\" \/>\n<meta property=\"og:locale\" content=\"en_US\" \/>\n<meta property=\"og:type\" content=\"article\" \/>\n<meta property=\"og:title\" content=\"Code Review on Modules | Tong Hin&#039;s Blog\" \/>\n<meta property=\"og:description\" content=\"For the last week of my internship, I&#8217;ve performed code review on each module that I responsible for. I&#8217;ve clean up some redundant codes and functions, renamed variables to be more understandable. Not only that, I&#8217;ve also wrote comments to clarify the implementation logic for some functions. Secondly, during the code review, I&#8217;ve also learned &hellip; Continue reading &quot;Code Review on Modules&quot;\" \/>\n<meta property=\"og:url\" content=\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\" \/>\n<meta property=\"og:site_name\" content=\"Tong Hin&#039;s Blog\" \/>\n<meta property=\"article:published_time\" content=\"2021-01-11T05:39:40+00:00\" \/>\n<meta property=\"article:modified_time\" content=\"2021-01-11T05:39:41+00:00\" \/>\n<meta name=\"twitter:card\" content=\"summary_large_image\" \/>\n<meta name=\"twitter:label1\" content=\"Est. reading time\">\n\t<meta name=\"twitter:data1\" content=\"1 minute\">\n<script type=\"application\/ld+json\" class=\"yoast-schema-graph\">{\"@context\":\"https:\/\/schema.org\",\"@graph\":[{\"@type\":\"Organization\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#organization\",\"name\":\"TONG HIN MACHINERY\",\"url\":\"https:\/\/www.tonghin.com.my\/blog\/\",\"sameAs\":[\"https:\/\/www.youtube.com\/channel\/UC60EoxJMNbu8mV0LuEGfrBg\"],\"logo\":{\"@type\":\"ImageObject\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#logo\",\"inLanguage\":\"en-US\",\"url\":\"https:\/\/www.tonghin.com.my\/blog\/wp-content\/uploads\/2020\/10\/web_logo_180_180.jpg\",\"width\":180,\"height\":180,\"caption\":\"TONG HIN MACHINERY\"},\"image\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#logo\"}},{\"@type\":\"WebSite\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#website\",\"url\":\"https:\/\/www.tonghin.com.my\/blog\/\",\"name\":\"Tong Hin&#039;s Blog\",\"description\":\"Sharing About Technology\",\"publisher\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#organization\"},\"potentialAction\":[{\"@type\":\"SearchAction\",\"target\":\"https:\/\/www.tonghin.com.my\/blog\/?s={search_term_string}\",\"query-input\":\"required name=search_term_string\"}],\"inLanguage\":\"en-US\"},{\"@type\":\"WebPage\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#webpage\",\"url\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\",\"name\":\"Code Review on Modules | Tong Hin&#039;s Blog\",\"isPartOf\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#website\"},\"datePublished\":\"2021-01-11T05:39:40+00:00\",\"dateModified\":\"2021-01-11T05:39:41+00:00\",\"breadcrumb\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#breadcrumb\"},\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"ReadAction\",\"target\":[\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\"]}]},{\"@type\":\"BreadcrumbList\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#breadcrumb\",\"itemListElement\":[{\"@type\":\"ListItem\",\"position\":1,\"item\":{\"@type\":\"WebPage\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/\",\"url\":\"https:\/\/www.tonghin.com.my\/blog\/\",\"name\":\"Home\"}},{\"@type\":\"ListItem\",\"position\":2,\"item\":{\"@type\":\"WebPage\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\",\"url\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/\",\"name\":\"Code Review on Modules\"}}]},{\"@type\":\"Article\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#article\",\"isPartOf\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#webpage\"},\"author\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#\/schema\/person\/b6d8e09279640ee3576051fb9790a8c8\"},\"headline\":\"Code Review on Modules\",\"datePublished\":\"2021-01-11T05:39:40+00:00\",\"dateModified\":\"2021-01-11T05:39:41+00:00\",\"mainEntityOfPage\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#webpage\"},\"commentCount\":0,\"publisher\":{\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#organization\"},\"keywords\":\"cleanup,codereview\",\"articleSection\":\"Experiential\",\"inLanguage\":\"en-US\",\"potentialAction\":[{\"@type\":\"CommentAction\",\"name\":\"Comment\",\"target\":[\"https:\/\/www.tonghin.com.my\/blog\/2021\/01\/11\/code-review-on-modules\/#respond\"]}]},{\"@type\":\"Person\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#\/schema\/person\/b6d8e09279640ee3576051fb9790a8c8\",\"name\":\"Chong Pui Man\",\"image\":{\"@type\":\"ImageObject\",\"@id\":\"https:\/\/www.tonghin.com.my\/blog\/#personlogo\",\"inLanguage\":\"en-US\",\"url\":\"https:\/\/secure.gravatar.com\/avatar\/34cf8e981acb44d194d4c713de79fd90?s=96&d=mm&r=g\",\"caption\":\"Chong Pui Man\"}}]}<\/script>\n<!-- \/ Yoast SEO plugin. -->","_links":{"self":[{"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/posts\/153"}],"collection":[{"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/users\/3"}],"replies":[{"embeddable":true,"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/comments?post=153"}],"version-history":[{"count":2,"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/posts\/153\/revisions"}],"predecessor-version":[{"id":155,"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/posts\/153\/revisions\/155"}],"wp:attachment":[{"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/media?parent=153"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/categories?post=153"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.tonghin.com.my\/blog\/wp-json\/wp\/v2\/tags?post=153"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}